commons-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Gilles (JIRA)" <>
Subject [jira] [Commented] (MATH-1250) ANN: add performance reporting
Date Sat, 18 Jul 2015 14:19:04 GMT


Gilles commented on MATH-1250:

Hi Phil.

bq.  'successful' is mis-spelled in the javadoc


bq. computeUpdateRatio  \[...\] doesn't guarantee consistent results.

I know.
But "computeUpdateRatio" is in the "test" part of the code repository.  For the exact reason
that I did not want to have more lines of code dedicated to housekeeping/statistics than for
the main task. The update of each field is consistent (thanks to the "AtomicLong" instances);
users will be responsible for how they use them in combination...  I might add a warning in
the Javadoc to that purpose.

As they are now, the calls to "computeUpdateRatio" will return a correct result (because the
"Network" is not updated anymore).

Thanks for the review.

> ANN: add performance reporting
> ------------------------------
>                 Key: MATH-1250
>                 URL:
>             Project: Commons Math
>          Issue Type: Improvement
>    Affects Versions: 3.5
>            Reporter: Gilles
>            Assignee: Gilles
>            Priority: Minor
>              Labels: API
>             Fix For: 4.0, 3.6
>         Attachments: MATH-1250.patch
> The {{Neuron}} objects (package "") can be updated concurrently.
> In order to figure out whether adding more CPUs to a task will improve or hinder performance,
it would be useful to be able to assess how many updates were completed successfully (i.e.
without another thread having changed the object's state concurrently).

This message was sent by Atlassian JIRA

View raw message