commons-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jochen Wiedmann (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FILEUPLOAD-235) FileItem.getName() does not conform to the Java File.getName behaviour and *returns* a full path when provided with one
Date Fri, 10 Jul 2015 08:08:04 GMT

    [ https://issues.apache.org/jira/browse/FILEUPLOAD-235?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14621949#comment-14621949
] 

Jochen Wiedmann commented on FILEUPLOAD-235:
--------------------------------------------

David: Commons Fileupload is a component, which is used in countless web applications all
over the world. We do take upwards compatibility very serious. Your proposal would break compatibility
without a compelling reason.

Sorry,

Jochen


> FileItem.getName() does not conform to the Java File.getName behaviour and *returns*
a full path when provided with one
> -----------------------------------------------------------------------------------------------------------------------
>
>                 Key: FILEUPLOAD-235
>                 URL: https://issues.apache.org/jira/browse/FILEUPLOAD-235
>             Project: Commons FileUpload
>          Issue Type: Bug
>    Affects Versions: 1.3
>            Reporter: David
>            Assignee: Jochen Wiedmann
>            Priority: Minor
>             Fix For: 2.x
>
>
> I understand that FileItem is simply following RFC 1867, but the implementation of 'getName'

> method on a file related class IMHO should follow the behaviour of the java File class
which
> bq. Returns the name of the file or directory denoted by this abstract pathname. This
is just the last name in the pathname's name sequence. If the pathname's name sequence is
empty, then the empty string is returned. http://docs.oracle.com/javase/7/docs/api/java/io/File.html#getName()
> I propose that FileItem.getName() is changed to *match* the java File class behaviour
and that another method called something like 'getRawName' be added to the FileItem class.
The rational for this change is to make it less easy to shoot oneself in the foot (in no modern
web application is a 'full filepath' useful, especially when most browsers do not send one!).



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message