commons-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From joehni <...@git.apache.org>
Subject [GitHub] commons-lang pull request: Changes in Capitalize methods in WordUt...
Date Mon, 06 Jul 2015 18:28:07 GMT
Github user joehni commented on the pull request:

    https://github.com/apache/commons-lang/pull/104#issuecomment-118948067
  
    Your changes introduce the conversion of the char array into a HashSet and back again
into an array. This is way too expensive. Keep the original array and iterate through it.
If you want to check for duplicates, you may create a 2nd array and add each processed character.
Then you can check any new delimieter character for the index in the 2nd array first.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message