Mailing-List: contact issues-help@commons.apache.org; run by ezmlm
Precedence: bulk
Reply-To: issues@commons.apache.org
Date: Wed, 17 Jun 2015 00:34:00 +0000 (UTC)
From: "Gary Gregory (JIRA)" <jira@apache.org>
To: issues@commons.apache.org
Message-ID: <JIRA.12837930.1434394816000.91742.1434501240476@Atlassian.JIRA>
In-Reply-To: <JIRA.12837930.1434394816000@Atlassian.JIRA>
References: <JIRA.12837930.1434394816000@Atlassian.JIRA>
 <JIRA.12837930.1434394816139@arcas>
Subject: [jira] [Commented] (CSV-152) CSVRecord.isSet() does not check if
 value is not null
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


    [ https://issues.apache.org/jira/browse/CSV-152?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14589089#comment-14589089 ] 

Gary Gregory commented on CSV-152:
----------------------------------

So in you use case, the record needs the format object or just the {{nullString}} setting?

> CSVRecord.isSet() does not check if value is not null
> -----------------------------------------------------
>
>                 Key: CSV-152
>                 URL: https://issues.apache.org/jira/browse/CSV-152
>             Project: Commons CSV
>          Issue Type: Bug
>            Reporter: Michael Newcomb
>
> Consider:
> public boolean isSet(final String name)
> {
>   return isMapped(name) && mapping.get(name).intValue() < values.length;
> }
> The docs say 'and has a value', however, it does not check if values[mapping.get(name)] is null.
> Propose:
> public boolean isSet(final String name)
> {
>   return isMapped(name) && mapping.get(name) < values.length && values[mapping.get(name)] != null;
> }
> Perhaps a new method 'hasValue' if the above is not desirable?


--
This message was sent by Atlassian JIRA
(v6.3.4#6332)