Return-Path: X-Original-To: apmail-commons-issues-archive@minotaur.apache.org Delivered-To: apmail-commons-issues-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 2446B18211 for ; Mon, 22 Jun 2015 19:26:06 +0000 (UTC) Received: (qmail 70076 invoked by uid 500); 22 Jun 2015 19:26:00 -0000 Delivered-To: apmail-commons-issues-archive@commons.apache.org Received: (qmail 69969 invoked by uid 500); 22 Jun 2015 19:26:00 -0000 Mailing-List: contact issues-help@commons.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: issues@commons.apache.org Delivered-To: mailing list issues@commons.apache.org Received: (qmail 69956 invoked by uid 99); 22 Jun 2015 19:26:00 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 22 Jun 2015 19:26:00 +0000 Date: Mon, 22 Jun 2015 19:26:00 +0000 (UTC) From: "Oliver Heger (JIRA)" To: issues@commons.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (LANG-1141) StrLookup.systemPropertiesLookup() no longer reacts on changes on system properties MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/LANG-1141?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14596495#comment-14596495 ] Oliver Heger commented on LANG-1141: ------------------------------------ I am fine with a different name. This test was from the original report for LANG-1055. > StrLookup.systemPropertiesLookup() no longer reacts on changes on system properties > ----------------------------------------------------------------------------------- > > Key: LANG-1141 > URL: https://issues.apache.org/jira/browse/LANG-1141 > Project: Commons Lang > Issue Type: Bug > Components: lang.text.* > Affects Versions: 3.4 > Reporter: Oliver Heger > Attachments: lang-1141.patch > > > In versions of Commons Lang before 3.4 a {{Lookup}} object created from the {{systemPropertiesLookup()}} method offered a live view of system properties. So if a system property was changed after the creation of the lookup object, the new value was visible. In version 3.4 this is no longer the case. > The change seems to be related to LANG-1055. Here a fix was implemented which initializes a lookup object for system properties with a snapshot copy of the current properties. Changes made later on system properties are no longer reflected. I do not understand the background for this change because this is not really related to the original bug report. > I would propose an implementation which fixes the reported problem in LANG-1055 and allows a live view on system properties. Maybe the snapshot use case could still be supported by an overloaded method. -- This message was sent by Atlassian JIRA (v6.3.4#6332)