Mailing-List: contact issues-help@commons.apache.org; run by ezmlm
Precedence: bulk
Reply-To: issues@commons.apache.org
Date: Fri, 12 Jun 2015 23:57:00 +0000 (UTC)
From: "Sebb (JIRA)" <jira@apache.org>
To: issues@commons.apache.org
Message-ID: <JIRA.12759452.1417707276000.62375.1434153420569@Atlassian.JIRA>
In-Reply-To: <JIRA.12759452.1417707276000@Atlassian.JIRA>
References: <JIRA.12759452.1417707276000@Atlassian.JIRA>
 <JIRA.12759452.1417707276503@arcas>
Subject: [jira] [Commented] (LANG-1075) Replace
 System.getProperty("file|path.separator") with File.separator|pathSeparator
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


    [ https://issues.apache.org/jira/browse/LANG-1075?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14584295#comment-14584295 ] 

Sebb commented on LANG-1075:
----------------------------

I'm not suggesting changing how FILE_SEPARATOR or PATH_SEPARATOR are initialised.
However, I think they should be deprecated in favour of the File class constants.

> Replace System.getProperty("file|path.separator") with File.separator|pathSeparator
> -----------------------------------------------------------------------------------
>
>                 Key: LANG-1075
>                 URL: https://issues.apache.org/jira/browse/LANG-1075
>             Project: Commons Lang
>          Issue Type: Improvement
>            Reporter: Sebb
>            Priority: Minor
>             Fix For: Patch Needed, 3.5
>
>
> The file separator character is available from both File.separator and System.getProperty("file.separator").
> The former is guaranteed to be a string of length 1, but the latter can be defined as a longer string on the Java command line. Thus the two can be different, but still allow the JVM to start up.
> I found the following worked:
> java -Dfile.separator=/xyz
> for Unix or the equivalent \xyz on Windows.
> [Using a different first character does not work - the JVM usually throws an
> exception as it cannot find some required files if the sep. is incorrect.]
> It looks like only the first character of the property is used by the JVM.
> However, this is not done by the application code I have seen, which means that there could be a discrepancy between the two methods.
> File.separator has the additional benefit that it is not subject to a privilege
> check.
> The same reasoning applies to "path.separator" => File.pathSeparator
> Commons code should always use the File constants.


--
This message was sent by Atlassian JIRA
(v6.3.4#6332)