commons-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From rikles <...@git.apache.org>
Subject [GitHub] commons-lang pull request: LANG-1147 : Fix EnumUtils *BitVector is...
Date Fri, 12 Jun 2015 08:25:02 GMT
GitHub user rikles opened a pull request:

    https://github.com/apache/commons-lang/pull/97

    LANG-1147 : Fix EnumUtils *BitVector issue with more than 32 values Enums

    In `EnumUtils` all _BitVector_ related methods fail in handling Enum with more than 32
values.
    This is due to a implicit `int` -> `long` conversion in generating the Enum value `long`
mask.
    
    ```java
    // Bad code : here `1` is an `int` value so the `<<` operation is done into an `int`
context and then, the result is converted to a `long` value
    long mask = 1 << 32;    // -> mask = 1 and not 4294967296 (0x100000000)
    
    // Good code : here `1L` is a `long` value so the `<<` operation is done into an
`long` context
    long mask = 1L << 32;    // -> mask = 4294967296 (0x100000000)
    ```
    
    I fixed this and add some tests into `EnumUtilsTest` with a 64 values Enum.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/rikles/commons-lang fix-LANG-1147

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/commons-lang/pull/97.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #97
    
----
commit 1c9e5139f2b515f8741fbcb9c9b0f398d22d73ca
Author: Loic Guibert <lfdummy-apache@yahoo.fr>
Date:   2015-06-12T08:19:37Z

    LANG-1147 : Fix EnumUtils *BitVector issue with more than 32 values Enums

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message