commons-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Sebb (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (IO-480) IOUtils.closeQuietly can throw NullPointerException
Date Thu, 04 Jun 2015 23:29:38 GMT

    [ https://issues.apache.org/jira/browse/IO-480?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14573794#comment-14573794
] 

Sebb commented on IO-480:
-------------------------

That seems like a bug in the InputStream implementation.
Does not seem right to catch Exceptions that are not supposed to be thrown by close(), so
I suggest closing this as won't fix

> IOUtils.closeQuietly can throw NullPointerException
> ---------------------------------------------------
>
>                 Key: IO-480
>                 URL: https://issues.apache.org/jira/browse/IO-480
>             Project: Commons IO
>          Issue Type: Bug
>          Components: Utilities
>    Affects Versions: 2.4
>            Reporter: Matt Kusnierz
>   Original Estimate: 10m
>  Remaining Estimate: 10m
>
> The IOUtils#closeQuietly method in its javadoc suggests that ANY exceptions will be ignored.
This is not the case, as the code only catches IOExceptions. As this example stack trace shows,
it is possible for some InputStreams to throw NullPointerExceptions during close:
> java.lang.NullPointerException: null
> 	at java.io.FilterInputStream.close(FilterInputStream.java:155) ~[na:1.6.0_35]
> 	at sun.net.www.protocol.jar.JarURLConnection$JarURLInputStream.close(JarURLConnection.java:90)
~[na:1.6.0_35]
> 	at org.apache.commons.io.IOUtils.closeQuietly(IOUtils.java:281) ~[commons-io-2.1.jar:2.1]
> 	at org.apache.commons.io.IOUtils.closeQuietly(IOUtils.java:224) ~[commons-io-2.1.jar:2.1]
> Close quietly should do as advertised/suggested and catch all Exceptions.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message