[ https://issues.apache.org/jira/browse/LANG-1130?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14576236#comment-14576236
]
Sebb commented on LANG-1130:
----------------------------
bq. the inner class TextField stores the user-supplied array 'values' directly.
This is OK because the only caller is the method 'parsePattern' which uses a local array that
cannot be changed subsequently.
It would not be OK if the array were passed in from an external source, as it could then be
changed later.
> Fix critical issues reported by SonarQube
> -----------------------------------------
>
> Key: LANG-1130
> URL: https://issues.apache.org/jira/browse/LANG-1130
> Project: Commons Lang
> Issue Type: Task
> Affects Versions: 3.5
> Reporter: Benedikt Ritter
> Assignee: Benedikt Ritter
> Fix For: 3.5
>
>
> The Apache SonarQube instance shows five critical warnings for Commons Lang: https://analysis.apache.org/dashboard/index/72046
> We should try to fix those.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
|