commons-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Kaspar-David Buss (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (BCEL-202) StackMapTableEntry.copy() needs to be deep; Improved support for StackMaps
Date Thu, 18 Jun 2015 03:04:00 GMT

    [ https://issues.apache.org/jira/browse/BCEL-202?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14591163#comment-14591163
] 

Kaspar-David Buss commented on BCEL-202:
----------------------------------------

It's been years since the StackMapTable has been introduced. That this still hasn't been addressed
is frankly mind-boggling.
I'd say this is actually a Blocker. The entire "Engineering" part of "Bytecode Engineering
Library" kind of falls apart when even adding a single NOP completely breaks most programs.

> StackMapTableEntry.copy() needs to be deep; Improved support for StackMaps
> --------------------------------------------------------------------------
>
>                 Key: BCEL-202
>                 URL: https://issues.apache.org/jira/browse/BCEL-202
>             Project: Commons BCEL
>          Issue Type: Bug
>            Reporter: Mark Roberts
>         Attachments: stackmap.diff
>
>
> There are several ways a user can modify a Java class file that should cause BCEL to
update the StackMaps automatically.  Unfortunately, it does not.  These additional methods
at least allow users to take care of these issues for themselves.
> The patch also fixes a bug - StackMapTableEntry.copy() needs to be a deep copy to prevent
StackMapTypes from being reused.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message