commons-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Ayoma Wijethunga (JIRA)" <j...@apache.org>
Subject [jira] [Comment Edited] (VALIDATOR-351) DomainValidator - allow access to internal arrays
Date Tue, 09 Jun 2015 09:43:00 GMT

    [ https://issues.apache.org/jira/browse/VALIDATOR-351?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14578638#comment-14578638
] 

Ayoma Wijethunga edited comment on VALIDATOR-351 at 6/9/15 9:42 AM:
--------------------------------------------------------------------

This is a request for comments and suggestions. 

My suggestion is that it is better to use Lists in storing custom TLDs. If clones of arrays
were used it will not be easy to provide a mechanism of reverting back to the originals (without
keeping original objects stored) and might introduce additional complexities in removing custom
additions.

I have attached a patch with this comment and I welcome any comments and suggestions regarding
how to further improve the patch. If the patch is up to expectation and is pointing towards
the correction direction, I can write additional unit tests and provide a full patch.





was (Author: ayomawdb):
This is a request for comments and suggestions. 

My suggestion is that it is better to use Lists in storing custom TLDs. If clones of arrays
were used it will not be easy to provide a mechanism of reverting back to the originals (without
keeping original objects stored) and might introduce additional complexities in removing custom
additions.

I have attached a patch with this comment and I welcome any comments and suggestions regarding
how to further improve the patch. If the patch is up to expectation and if pointing towards
to correction direction, I can write additional unit tests and provide a full patch.




> DomainValidator - allow access to internal arrays
> -------------------------------------------------
>
>                 Key: VALIDATOR-351
>                 URL: https://issues.apache.org/jira/browse/VALIDATOR-351
>             Project: Commons Validator
>          Issue Type: Improvement
>            Reporter: Sebb
>         Attachments: RequestForComments.patch
>
>
> Seems to me it might be useful to allow users access to the current lists of TLD entries.
This could be done with a simple clone of the array. 
> It might also be useful to have a public constant containing the version of the IANA
file from which the entries were last updated.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message