commons-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Gary Gregory (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CSV-104) Split CSVRecord with a subclass for mapping ops.
Date Mon, 15 Jun 2015 23:35:00 GMT

    [ https://issues.apache.org/jira/browse/CSV-104?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14587143#comment-14587143
] 

Gary Gregory commented on CSV-104:
----------------------------------

The patch does not apply cleanly on top of SVN trunk. Can you provide an updated patch

> Split CSVRecord with a subclass for mapping ops.
> ------------------------------------------------
>
>                 Key: CSV-104
>                 URL: https://issues.apache.org/jira/browse/CSV-104
>             Project: Commons CSV
>          Issue Type: Improvement
>          Components: Parser
>         Environment: Apache Maven 3.1.1 (0728685237757ffbf44136acec0402957f723d9a; 2013-09-17
11:22:22-0400)
> Maven home: C:\Java\apache-maven-3.1.1\bin\..
> Java version: 1.7.0_51, vendor: Oracle Corporation
> Java home: C:\Program Files\Java\jdk1.7.0_51\jre
> Default locale: en_US, platform encoding: Cp1252
> OS name: "windows 7", version: "6.1", arch: "amd64", family: "windows"
>            Reporter: Gary Gregory
>             Fix For: Review, 1.x
>
>         Attachments: CSV-104.diff, CSV-104.patch
>
>
> Either a CSV file has headers or it does not.
> Currently, the class CSVRecord is a catch all for both cases.
> This patch refactors the code with a CSVRecord class CSVMappedRecord. The class could
also be called CSVRecordMap.
> The patch does not push the use of generics all the way. All tests compile.
> Furthermore, the idea is that the CSVMappedRecord class will implement Map<String,
String>, which is what I really want.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message