Return-Path: X-Original-To: apmail-commons-issues-archive@minotaur.apache.org Delivered-To: apmail-commons-issues-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id C368718D9A for ; Thu, 14 May 2015 09:06:00 +0000 (UTC) Received: (qmail 86209 invoked by uid 500); 14 May 2015 09:06:00 -0000 Delivered-To: apmail-commons-issues-archive@commons.apache.org Received: (qmail 86097 invoked by uid 500); 14 May 2015 09:06:00 -0000 Mailing-List: contact issues-help@commons.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: issues@commons.apache.org Delivered-To: mailing list issues@commons.apache.org Received: (qmail 86085 invoked by uid 99); 14 May 2015 09:06:00 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 14 May 2015 09:06:00 +0000 Date: Thu, 14 May 2015 09:06:00 +0000 (UTC) From: "Mark Thomas (JIRA)" To: issues@commons.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (POOL-285) GenericKeyedObjectPool.returnObject() checks for idle object too late MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/POOL-285?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14543411#comment-14543411 ] Mark Thomas commented on POOL-285: ---------------------------------- +1 > GenericKeyedObjectPool.returnObject() checks for idle object too late > --------------------------------------------------------------------- > > Key: POOL-285 > URL: https://issues.apache.org/jira/browse/POOL-285 > Project: Commons Pool > Issue Type: Bug > Affects Versions: 2.0, 2.1, 2.2, 2.3 > Reporter: Sebb > Fix For: 2.4 > > > GenericKeyedObjectPool.returnObject() checks if the object was already returned to the pool after it has performed validation (if reqd) and after the object has been passivated. > This seems wrong - surely if the object has already been returned to the pool it should not be validated or passivated again? -- This message was sent by Atlassian JIRA (v6.3.4#6332)