Return-Path: X-Original-To: apmail-commons-issues-archive@minotaur.apache.org Delivered-To: apmail-commons-issues-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id D5EDC17DCD for ; Mon, 4 May 2015 07:36:05 +0000 (UTC) Received: (qmail 26263 invoked by uid 500); 4 May 2015 07:36:05 -0000 Delivered-To: apmail-commons-issues-archive@commons.apache.org Received: (qmail 26168 invoked by uid 500); 4 May 2015 07:36:05 -0000 Mailing-List: contact issues-help@commons.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: issues@commons.apache.org Delivered-To: mailing list issues@commons.apache.org Received: (qmail 26155 invoked by uid 99); 4 May 2015 07:36:05 -0000 Received: from git1-us-west.apache.org (HELO git1-us-west.apache.org) (140.211.11.23) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 04 May 2015 07:36:05 +0000 Received: by git1-us-west.apache.org (ASF Mail Server at git1-us-west.apache.org, from userid 33) id 3536CDFBDE; Mon, 4 May 2015 07:36:05 +0000 (UTC) From: CodingFabian To: issues@commons.apache.org Reply-To: issues@commons.apache.org References: In-Reply-To: Subject: [GitHub] commons-lang pull request: Add ThreadUtils (2nd PR) Content-Type: text/plain Message-Id: <20150504073605.3536CDFBDE@git1-us-west.apache.org> Date: Mon, 4 May 2015 07:36:05 +0000 (UTC) Github user CodingFabian commented on the pull request: https://github.com/apache/commons-lang/pull/78#issuecomment-98610476 Thank you @salyh for your work on this. Overall I like the API and the implementation. I added two comments. Also it looks like your formatter settings are not used. some spaces are missing (like i=0 instead of i = 0) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastructure@apache.org or file a JIRA ticket with INFRA. ---