commons-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Adrian Ber (JIRA)" <j...@apache.org>
Subject [jira] [Comment Edited] (LANG-1122) Inconsistent behavior of swap for malformed inputs
Date Mon, 04 May 2015 19:23:06 GMT

    [ https://issues.apache.org/jira/browse/LANG-1122?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14526414#comment-14526414
] 

Adrian Ber edited comment on LANG-1122 at 5/4/15 7:22 PM:
----------------------------------------------------------

For case 5, even if we promote len to zero, it will have the same result - no op.
If we will use the principle "swap as many as possible from the given offset onwards" in all
cases then 5 and 6 will promote the indices to zero. And then it will be consistent with 9
and 10 behavior too. And it will also be easy to document it too :).
What do you think?


was (Author: beradrian):
For case 5, even if we promote len to zero, it will have the same result - no op.
If we will use the principle "swap as many as possible from the given offset onwards" in all
cases then 5 and 6 will promote the indices to zero. And then it will be consistent with 9
and 10 behavior too. And then it will also be easy to document it too :).
What do you think?

> Inconsistent behavior of swap for malformed inputs
> --------------------------------------------------
>
>                 Key: LANG-1122
>                 URL: https://issues.apache.org/jira/browse/LANG-1122
>             Project: Commons Lang
>          Issue Type: Bug
>          Components: lang.*
>            Reporter: Benedikt Ritter
>             Fix For: Patch Needed, 3.5
>
>
> Following the discussion at https://github.com/apache/commons-lang/pull/47 we need to
decide how malformed inputs should be handled by the swap method. We have to handle several
forms of malformed inputs and we should decide how to do that based on the current behavior
of ArrayUtils. Malformed inputs are:
> # array == null
> # array.length == 0
> # offset1 < 0
> # offset2 < 0
> # len < 0
> # offset1 > offset2
> # offset1 > array.length
> # offset2 > array.length
> # offset1 + len > array.length
> # offset2 + len > array.length



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message