commons-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From britter <...@git.apache.org>
Subject [GitHub] commons-lang pull request: LANG-740 - Implementation of a Memomize...
Date Tue, 05 May 2015 18:24:28 GMT
Github user britter commented on a diff in the pull request:

    https://github.com/apache/commons-lang/pull/80#discussion_r29697345
  
    --- Diff: src/test/java/org/apache/commons/lang3/concurrent/MemoizerTest.java ---
    @@ -0,0 +1,112 @@
    +package org.apache.commons.lang3.concurrent;
    +
    +import org.easymock.EasyMockRunner;
    +import org.easymock.Mock;
    +import org.junit.Test;
    +import org.junit.runner.RunWith;
    +
    +import static org.easymock.EasyMock.expect;
    +import static org.easymock.EasyMock.replay;
    +import static org.junit.Assert.assertEquals;
    +import static org.junit.Assert.fail;
    +
    +@RunWith(EasyMockRunner.class)
    +public class MemoizerTest {
    --- End diff --
    
    Wouldn't it make sense to create a test that uses an executor service to let several threads
in parallel access the same Memoizer instance?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message