commons-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From chonton <...@git.apache.org>
Subject [GitHub] commons-lang pull request: LANG-1127: Use JUnit rules to set and r...
Date Mon, 04 May 2015 16:55:35 GMT
Github user chonton commented on the pull request:

    https://github.com/apache/commons-lang/pull/76#issuecomment-98777778
  
    Overall, I like this approach better than explicit classes.  Two items I would like to
see:
    1. Allow tests to run in parallel.  This will probably requires some sort of synchronization
to allow only one tests at a time to change default TimeZone or Locale.
    2. Apply the rule to individual test methods instead of to all methods in a test class.
 Perhaps this could be done by creating annotation(s) which enable the Rule.  I am thinking
of something like SwitchDefaults(locale="locale_name", timezone="timezone_name").


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message