commons-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (LANG-1118) StringUtils.repeat('z', -1) throws NegativeArraySizeException
Date Tue, 28 Apr 2015 15:35:06 GMT

    [ https://issues.apache.org/jira/browse/LANG-1118?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14517216#comment-14517216
] 

ASF GitHub Bot commented on LANG-1118:
--------------------------------------

GitHub user rikles opened a pull request:

    https://github.com/apache/commons-lang/pull/72

     LANG-1118: Fix StringUtils.repeat(char, int)

    _Close PR #68. Recreated due to rebase on master._
    
    Now doing what is said in JavaDoc comment :
    when passing a negative repeat value to the *StringUtils.repeat(char, int)* function,
it returns an empty String instead of throwing a _NegativeArraySizeException_.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/rikles/commons-lang fix-LANG-1118

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/commons-lang/pull/72.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #72
    
----
commit 78b30f509834d81b8814d46471b75e3167a6460f
Author: Loic Guibert <lfdummy-apache@yahoo.fr>
Date:   2015-04-23T11:41:51Z

    LANG-1118 Fix StringUtils.repeat(char, int) dealing with negative repeat value

commit 9cc91332ff252f6e3f41719526f930dcb5908c31
Author: Loic Guibert <lfdummy-apache@yahoo.fr>
Date:   2015-04-23T11:43:21Z

    LANG-1118 Adding a test case for StringUtils.repeat(String, int) checking dealing with
negative repeat value

----


> StringUtils.repeat('z', -1) throws NegativeArraySizeException
> -------------------------------------------------------------
>
>                 Key: LANG-1118
>                 URL: https://issues.apache.org/jira/browse/LANG-1118
>             Project: Commons Lang
>          Issue Type: Bug
>          Components: lang.*
>            Reporter: Loic Guibert
>            Assignee: Benedikt Ritter
>            Priority: Minor
>
> Unlike what is said in JavaDoc comment, when passing a negative repeat value to the *StringUtils.repeat(char,
int)* function, it doesn't return an empty String but throws a _NegativeArraySizeException_.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message