commons-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Benedikt Ritter (JIRA)" <>
Subject [jira] [Commented] (LANG-1115) Add support for varargs in ConstructorUtils, MemberUtils, and MethodUtils
Date Sat, 18 Apr 2015 18:36:59 GMT


Benedikt Ritter commented on LANG-1115:

Hello [~joeferner],

very nice and useful patch. I've looked through the code and here are my findings:
* ConstructorUtilsTest currently doesn't check whether the right arguments were passed to
the invoked constructor of TestBean. However for a constructor taking varagrs, I think we
should assign the passed in varargs array and compare it to what we passed in.
* In MemberUtils there is a long comment at the start of {{float getTotalTransformationCost(final
Class<?>[] srcArgs, final Class<?>[] destArgs, boolean isVarArgs)}}. How about
making this information explicit by assigning boolean values like {{boolean noVarArgsPassed
= src.length + 1 == dest.length}}.
* Furthermore in MemberUtils, I'm not sure I like the {{isVarArgs}} flag. I think I would
rather linke to have two separate methods.
* Can you please explain what {{Object[] getVarArgs(Object[] args, Class<?>[] methodParameterTypes)}}
int MethodUtils exactly does? I don't understand the code :)
* Checking input varargs arguments would be good in MethodUtilsTest

Thank you!

> Add support for varargs in ConstructorUtils, MemberUtils, and MethodUtils
> -------------------------------------------------------------------------
>                 Key: LANG-1115
>                 URL:
>             Project: Commons Lang
>          Issue Type: Improvement
>          Components: lang.reflect.*
>            Reporter: Joe Ferner
>            Priority: Minor
>             Fix For: Review Patch
>         Attachments: LANG-1115.patch
> Currently when calling methods such as MethodUtils.getMatchingAccessibleMethod variable
arguments are not supported. It would be nice if by calling getMatchingAccessibleMethod with
arguments that the java compiler would normally match with a vararg method would be matched.

This message was sent by Atlassian JIRA

View raw message