commons-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "andrew coates (JIRA)" <>
Subject [jira] [Created] (LANG-1114) TypeUtils.ParameterizedType#equals doesn't work with wildcard types
Date Tue, 14 Apr 2015 19:10:17 GMT
andrew coates created LANG-1114:

             Summary: TypeUtils.ParameterizedType#equals doesn't work with wildcard types
                 Key: LANG-1114
             Project: Commons Lang
          Issue Type: Bug
          Components: lang.reflect.*
    Affects Versions: 3.4, 3.3.2
            Reporter: andrew coates

There is a bug in TypeUtils.equals(WilcardType, Type).  It returns true if the other type
is not a WildcardType, it should return false.  See TypeUtils@1629 for v3.3.2 and TypeUtils@791
for v3.4

Bug can be seen with the following test:

    public void shouldHandleEqualityOfParameterizedTypesWithWildcards() throws Exception {
        // Given:
        class SomeType {
            Collection<?> field;

        final ParameterizedType wildcardCollectionType = (ParameterizedType) SomeType.class.getDeclaredField("field").getGenericType();
        final WildcardType wildcard = (WildcardType) wildcardCollectionType.getActualTypeArguments()[0];
        final ParameterizedType ptWithWildcard = TypeUtils.parameterize(Collection.class,
        final ParameterizedType otherPt = TypeUtils.parameterize(Collection.class, String.class);

        // Then:
        assertThat(otherPt, is(not(equalTo(ptWithWildcard))));  // Passes
        assertThat(ptWithWildcard, is(not(equalTo(otherPt))));  // Fails

This message was sent by Atlassian JIRA

View raw message