commons-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "BELUGA BEHR (JIRA)" <j...@apache.org>
Subject [jira] [Updated] (EXEC-92) StreamPumper - Check For EOF
Date Tue, 17 Mar 2015 00:57:38 GMT

     [ https://issues.apache.org/jira/browse/EXEC-92?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

BELUGA BEHR updated EXEC-92:
----------------------------
    Description: 
When the StreamPumper is copying data from the InputStream to the OutputStream, it would be
safer to check for EOF instead of a read size greater than zero to protect against InputStream
implementations that don't respect the contract as defined in Java core JavaDoc.

Patch Included.  I took code from the copy method of the IOUtils class.

{code:title=StreamPumper.java|borderStyle=solid}
while ((length = is.read(buf)) > 0)
{
    os.write(buf, 0, length);
}
{code}

  was:
When the StreamPumper is copying data from the InputStream to the OutputStream, it would be
safer to check for EOF instead of a read size greater than zero to protect against InputStream
implementations that don't respect the contract as defined in Java core JavaDoc.

Patch Included.  I took code from the copy method of the IOUtils class.

{{
            while ((length = is.read(buf)) > 0) {
                os.write(buf, 0, length);
            }
}}


> StreamPumper - Check For EOF
> ----------------------------
>
>                 Key: EXEC-92
>                 URL: https://issues.apache.org/jira/browse/EXEC-92
>             Project: Commons Exec
>          Issue Type: Bug
>    Affects Versions: 1.3
>            Reporter: BELUGA BEHR
>             Fix For: 1.4
>
>         Attachments: StreamPumper.java.patch
>
>
> When the StreamPumper is copying data from the InputStream to the OutputStream, it would
be safer to check for EOF instead of a read size greater than zero to protect against InputStream
implementations that don't respect the contract as defined in Java core JavaDoc.
> Patch Included.  I took code from the copy method of the IOUtils class.
> {code:title=StreamPumper.java|borderStyle=solid}
> while ((length = is.read(buf)) > 0)
> {
>     os.write(buf, 0, length);
> }
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message