commons-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Thomas Neidhart (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (EMAIL-151) ImageHtmlEmail uses wrong name for embed() call
Date Mon, 09 Mar 2015 22:05:38 GMT

    [ https://issues.apache.org/jira/browse/EMAIL-151?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14353733#comment-14353733
] 

Thomas Neidhart commented on EMAIL-151:
---------------------------------------

Good catch, this must be wrong indeed.

> ImageHtmlEmail uses wrong name for embed() call
> -----------------------------------------------
>
>                 Key: EMAIL-151
>                 URL: https://issues.apache.org/jira/browse/EMAIL-151
>             Project: Commons Email
>          Issue Type: Bug
>    Affects Versions: 1.3.3
>            Reporter: Andreas Kohn
>         Attachments: email151-use-calculated-name-for-embed.diff
>
>
> Found by reading the code: ImageHtmlEmail#replacePattern() asks the DataSourceResolver
for a DataSource, and if the name of the data source is null/empty uses the resource location
as name for looking up the CID. 
> But, if that didn't work out it tries to embed the data source using the original 'null'
name instead, which fails with an exception.
> Trivial patch attached.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message