commons-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Andreas Kohn (JIRA)" <>
Subject [jira] [Created] (EMAIL-151) ImageHtmlEmail uses wrong name for embed() call
Date Mon, 09 Mar 2015 11:00:41 GMT
Andreas Kohn created EMAIL-151:

             Summary: ImageHtmlEmail uses wrong name for embed() call
                 Key: EMAIL-151
             Project: Commons Email
          Issue Type: Bug
    Affects Versions: 1.3.3
            Reporter: Andreas Kohn

Found by reading the code: ImageHtmlEmail#replacePattern() asks the DataSourceResolver for
a DataSource, and if the name of the data source is null/empty uses the resource location
as name for looking up the CID. 

But, if that didn't work out it tries to embed the data source using the original 'null' name
instead, which fails with an exception.

Trivial patch attached.

This message was sent by Atlassian JIRA

View raw message