commons-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Mark Thomas (JIRA)" <j...@apache.org>
Subject [jira] [Resolved] (BCEL-196) why is Instruction.setOpcode private?
Date Sat, 07 Mar 2015 09:36:38 GMT

     [ https://issues.apache.org/jira/browse/BCEL-196?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Mark Thomas resolved BCEL-196.
------------------------------
    Resolution: Won't Fix

Each opcode has a dedicated sub-class. Changing the opCode would require changing the sub-class.

I think I would have written this differently and tried to make opCode final. A quick look
at the code suggests that this would be possible. I could refactor the code that way but I
think there are more useful things I could be doing than implementing a refactoring that is
more about style than it is substance.

> why is Instruction.setOpcode private?
> -------------------------------------
>
>                 Key: BCEL-196
>                 URL: https://issues.apache.org/jira/browse/BCEL-196
>             Project: Commons BCEL
>          Issue Type: Bug
>            Reporter: Mark Roberts
>         Attachments: instruction.diff
>
>
> Am I missing another way to modify an instruction opcode?  Deleting and recreating does
not appear to be a good alternative due to having to deal with target pointers. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message