commons-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (LANG-935) Possible performance improvement on string escape functions
Date Mon, 23 Mar 2015 09:43:11 GMT

    [ https://issues.apache.org/jira/browse/LANG-935?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14375629#comment-14375629
] 

ASF GitHub Bot commented on LANG-935:
-------------------------------------

GitHub user CodingFabian opened a pull request:

    https://github.com/apache/commons-lang/pull/56

    Some minor fixup of LANG-935.

    Avoid toString() of the replacement sequence by doing it once.
    Avoid calculating the maximum when not needed.
    Fixup comment for greedy algorithm.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/CodingFabian/commons-lang LANG-935-additions

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/commons-lang/pull/56.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #56
    
----
commit b8a7b292e52b88ee6fc88159dcfd7860920b8ad0
Author: Fabian Lange <lange.fabian@gmail.com>
Date:   2015-03-23T09:37:09Z

    Some minor fixup of LANG-935.
    
    Avoid toString() of the replacement sequence by doing it once.
    Avoid calculating the maximum when not needed.
    Fixup comment for greedy algorithm.

----


> Possible performance improvement on string escape functions
> -----------------------------------------------------------
>
>                 Key: LANG-935
>                 URL: https://issues.apache.org/jira/browse/LANG-935
>             Project: Commons Lang
>          Issue Type: Improvement
>          Components: lang.text.translate.*
>    Affects Versions: 3.1
>            Reporter: Peter Wall
>            Priority: Minor
>              Labels: performance
>             Fix For: 3.4
>
>         Attachments: LANG-935.patch, tempproject1.zip
>
>
> The escape functions for HTML etc. use the same code and the same initialisation tables
for the escape and unescape functions, and while this is an elegant approach it leads to a
number of deficiencies:
> 1. The code is very much less efficient than it could be
> 2. A new output string is created even when no conversion is required
> 3. No mapping is provided for characters that do not have a specific representation (for
example HTML 0x101 should become &amp;#257; )
> The proposal is to use a new mapping technique to address these issues



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message