Return-Path: X-Original-To: apmail-commons-issues-archive@minotaur.apache.org Delivered-To: apmail-commons-issues-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 80FF3177EC for ; Fri, 20 Feb 2015 16:45:13 +0000 (UTC) Received: (qmail 36686 invoked by uid 500); 20 Feb 2015 16:45:13 -0000 Delivered-To: apmail-commons-issues-archive@commons.apache.org Received: (qmail 36593 invoked by uid 500); 20 Feb 2015 16:45:13 -0000 Mailing-List: contact issues-help@commons.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: issues@commons.apache.org Delivered-To: mailing list issues@commons.apache.org Received: (qmail 36581 invoked by uid 99); 20 Feb 2015 16:45:13 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 20 Feb 2015 16:45:13 +0000 Date: Fri, 20 Feb 2015 16:45:13 +0000 (UTC) From: "Stefan Bodewig (JIRA)" To: issues@commons.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Resolved] (COMPRESS-308) ZipEncodingHelper calls System.getProperty("file.encoding"); should use Charset.defaultCharset() MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/COMPRESS-308?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Stefan Bodewig resolved COMPRESS-308. ------------------------------------- Resolution: Fixed Fix Version/s: 1.10 fixed with svn revision 1661157 > ZipEncodingHelper calls System.getProperty("file.encoding"); should use Charset.defaultCharset() > ------------------------------------------------------------------------------------------------ > > Key: COMPRESS-308 > URL: https://issues.apache.org/jira/browse/COMPRESS-308 > Project: Commons Compress > Issue Type: Bug > Reporter: Sebb > Priority: Minor > Fix For: 1.10 > > > ZipEncodingHelper calls System.getProperty("file.encoding") > However this can fail with a security exception. > It should use Charset.defaultCharset() instead. > This method also uses System.getProperty but does so as part of a doPrivileged block. > AIUI this will be done in the protection domain of the JVM classes rather than the domain in which the Compress code runs, so should be less likely to fail. -- This message was sent by Atlassian JIRA (v6.3.4#6332)