Return-Path: 
 <issues-return-46153-apmail-commons-issues-archive=commons.apache.org@commons.apache.org>
X-Original-To: apmail-commons-issues-archive@minotaur.apache.org
Delivered-To: apmail-commons-issues-archive@minotaur.apache.org
Received: from mail.apache.org (hermes.apache.org [140.211.11.3])
	by minotaur.apache.org (Postfix) with SMTP id E88CD17545
	for <apmail-commons-issues-archive@minotaur.apache.org>;
 Sun,  8 Feb 2015 16:05:34 +0000 (UTC)
Received: (qmail 39229 invoked by uid 500); 8 Feb 2015 16:05:34 -0000
Delivered-To: apmail-commons-issues-archive@commons.apache.org
Received: (qmail 39137 invoked by uid 500); 8 Feb 2015 16:05:34 -0000
Mailing-List: contact issues-help@commons.apache.org; run by ezmlm
Precedence: bulk
List-Help: <mailto:issues-help@commons.apache.org>
List-Unsubscribe: <mailto:issues-unsubscribe@commons.apache.org>
List-Post: <mailto:issues@commons.apache.org>
List-Id: <issues.commons.apache.org>
Reply-To: issues@commons.apache.org
Delivered-To: mailing list issues@commons.apache.org
Received: (qmail 39125 invoked by uid 99); 8 Feb 2015 16:05:34 -0000
Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28)
    by apache.org (qpsmtpd/0.29) with ESMTP; Sun, 08 Feb 2015 16:05:34 +0000
Date: Sun, 8 Feb 2015 16:05:34 +0000 (UTC)
From: =?utf-8?Q?Michael_Gro=C3=9F_=28JIRA=29?= <jira@apache.org>
To: issues@commons.apache.org
Message-ID: <JIRA.12773301.1423411506000.295112.1423411534396@Atlassian.JIRA>
In-Reply-To: <JIRA.12773301.1423411506000@Atlassian.JIRA>
References: <JIRA.12773301.1423411506000@Atlassian.JIRA>
 <JIRA.12773301.1423411506163@arcas>
Subject: [jira] [Created] (IMAGING-165) TiffReader.Collector adds values to
 a field List<TiffField> but never uses it
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394

Michael Gro=C3=9F created IMAGING-165:
------------------------------------

             Summary: TiffReader.Collector adds values to a field List<Tiff=
Field> but never uses it
                 Key: IMAGING-165
                 URL: https://issues.apache.org/jira/browse/IMAGING-165
             Project: Commons Imaging
          Issue Type: Improvement
            Reporter: Michael Gro=C3=9F
             Fix For: Patch Needed


org.apache.commons.imaging.formats.tiff.TiffReader.Collector adds values to=
 a field List<TiffField> but never uses it. This could be the cause of some=
 problems reported elsewhere.

TiffReader contains an embedded class named Collector. This class has a pri=
vate field named
{noformat}
private static class Collector implements Listener {
        private final List<TiffField> fields =3D new ArrayList<TiffField>()=
;
{noformat}
There are values added in a method named
{noformat}
public boolean addField(final TiffField field) {
     fields.add(field);
     return true;
}
{noformat}
This method is the only which uses this field so these values are never use=
d. Is there a getter missing? Or was it intended to use these values in cla=
ss TiffContents like "tiffHeader" and "directories"?
{noformat}
public TiffContents getContents() {
    return new TiffContents(tiffHeader, directories);
}
{noformat}
At least the method "addField" seems unused but necessary to implement the =
"Listener" interface.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)