commons-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Stefan Bodewig (JIRA)" <j...@apache.org>
Subject [jira] [Resolved] (COMPRESS-308) ZipEncodingHelper calls System.getProperty("file.encoding"); should use Charset.defaultCharset()
Date Fri, 20 Feb 2015 16:45:13 GMT

     [ https://issues.apache.org/jira/browse/COMPRESS-308?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Stefan Bodewig resolved COMPRESS-308.
-------------------------------------
       Resolution: Fixed
    Fix Version/s: 1.10

fixed with svn revision 1661157

> ZipEncodingHelper calls System.getProperty("file.encoding"); should use Charset.defaultCharset()
> ------------------------------------------------------------------------------------------------
>
>                 Key: COMPRESS-308
>                 URL: https://issues.apache.org/jira/browse/COMPRESS-308
>             Project: Commons Compress
>          Issue Type: Bug
>            Reporter: Sebb
>            Priority: Minor
>             Fix For: 1.10
>
>
> ZipEncodingHelper calls System.getProperty("file.encoding")
> However this can fail with a security exception.
> It should use Charset.defaultCharset() instead.
> This method also uses System.getProperty but does so as part of a doPrivileged block.
> AIUI this will be done in the protection domain of the JVM classes rather than the domain
in which the Compress code runs, so should be less likely to fail.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message