commons-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Sebb (JIRA)" <j...@apache.org>
Subject [jira] [Created] (COMPRESS-302) Retore immutability to ArchiveStremFactory
Date Sun, 15 Feb 2015 17:35:11 GMT
Sebb created COMPRESS-302:
-----------------------------

             Summary: Retore immutability to ArchiveStremFactory
                 Key: COMPRESS-302
                 URL: https://issues.apache.org/jira/browse/COMPRESS-302
             Project: Commons Compress
          Issue Type: Bug
            Reporter: Sebb


COMPRESS-180 added support for encoding.
Unfortunately this was done in a way that broke immutability.
Also the factory is no longer thread-safe as the encoding field is not synch/volatile.

Consider whether to restore immutability, e.g. by adding a constuctor which takes the encoding
setting. The setEntryEncoding method could be deprecated intitially and eventually dropped.

One way to support immutability now would be to add a second final encoding field which is
set by a new ctor. See patch to follow.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message