commons-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Benedikt Ritter (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (IMAGING-166) ByteSourceImageTest: Local variable hides a field
Date Thu, 19 Feb 2015 06:48:11 GMT

    [ https://issues.apache.org/jira/browse/IMAGING-166?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14327048#comment-14327048
] 

Benedikt Ritter commented on IMAGING-166:
-----------------------------------------

Please create a PR at github. This will make reviewing easier.

> ByteSourceImageTest: Local variable hides a field
> -------------------------------------------------
>
>                 Key: IMAGING-166
>                 URL: https://issues.apache.org/jira/browse/IMAGING-166
>             Project: Commons Imaging
>          Issue Type: Task
>          Components: imaging.common.*
>            Reporter: Michael GroƟ
>            Priority: Minor
>              Labels: github
>             Fix For: Review Patch
>
>
> Testclass org.apache.commons.imaging.common.bytesource.ByteSourceImageTest::checkGetBufferedImage(...)
> There is a variable *imageFile* in this methods which hides the field *imageFile* in
this class. Can be fixed by renaming the variable *imageFile*.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message