commons-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Mark Roberts (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (BCEL-208) Need to check for an empty InstructionList
Date Fri, 20 Feb 2015 00:10:11 GMT

    [ https://issues.apache.org/jira/browse/BCEL-208?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14328359#comment-14328359
] 

Mark Roberts commented on BCEL-208:
-----------------------------------

Well, several of your existing test cases create methods with a null InstructionList.  :-)
  By design, the BCEL API covers just about every facet of reading or writing a Java class
file.  It's not hard to imagine users calling the various methods in unexpected (and incorrect)
orders.  In the process of studying this example in more detail I found that one of the patches
was not needed and an additional patch was needed elsewhere.  I have attached a new diff file
with the revised patch and a test case that demonstrates the problem.

> Need to check for an empty InstructionList
> ------------------------------------------
>
>                 Key: BCEL-208
>                 URL: https://issues.apache.org/jira/browse/BCEL-208
>             Project: Commons BCEL
>          Issue Type: Bug
>            Reporter: Mark Roberts
>         Attachments: b208.diff
>
>
> A couple of methods in MethodGen.java needed to test for an empty InstructionList.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message