commons-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Stefan Bodewig (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (COMPRESS-300) LZWInputStream has mutable protected fields; these should be accessed via getter/setter and made private
Date Thu, 05 Feb 2015 09:27:35 GMT

    [ https://issues.apache.org/jira/browse/COMPRESS-300?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14306905#comment-14306905
] 

Stefan Bodewig commented on COMPRESS-300:
-----------------------------------------

Given [~damjan]'s comments on the dev list, it may be more appropriate to add full setters
so subclasses in imaging are still able to do whatever they need to do.

> LZWInputStream has mutable protected fields; these should be accessed via getter/setter
and made private
> --------------------------------------------------------------------------------------------------------
>
>                 Key: COMPRESS-300
>                 URL: https://issues.apache.org/jira/browse/COMPRESS-300
>             Project: Commons Compress
>          Issue Type: Bug
>            Reporter: Sebb
>         Attachments: COMPRESS-300.patch
>
>
> As per the discussion on the dev list, the class LZWInputStream has some non-private
mutable fields.
> These should be accessed via getters/setters only (data encapsulation).



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message