commons-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Phil Steitz (JIRA)" <j...@apache.org>
Subject [jira] [Updated] (POOL-284) "Returned object not currently part of this pool" when using mutable objects
Date Sun, 22 Feb 2015 20:55:12 GMT

     [ https://issues.apache.org/jira/browse/POOL-284?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Phil Steitz updated POOL-284:
-----------------------------
    Attachment: pool-283-4.patch

Some WIP to review and performance test.  Passes the (disabled) tests for this issue and POOL-283.
 Replaces ConcurrentHashMap with a slightly modified StaticBucketMap from Commons Collections.

I did not set up configurability; but we could make the allObjects map type configurable,
using something like this patch when the requirements of this issue and / or pool-283 are
required.

> "Returned object not currently part of this pool" when using mutable objects
> ----------------------------------------------------------------------------
>
>                 Key: POOL-284
>                 URL: https://issues.apache.org/jira/browse/POOL-284
>             Project: Commons Pool
>          Issue Type: Bug
>    Affects Versions: 2.2
>            Reporter: Valentin Mayamsin
>         Attachments: pool-283-4.patch
>
>
> I'm using pool to reuse expensive Sets (storing millions of items). Here is a test which
fails:
> {code}
>         GenericObjectPoolConfig config = new GenericObjectPoolConfig ();
>         GenericObjectPool<Set> aPool = new GenericObjectPool<> ( new BasePooledObjectFactory<Set>
()
>         {
>             @Override
>             public Set create () throws Exception
>             {
>                 return new HashSet();
>             }
>             @Override
>             public PooledObject<Set> wrap ( Set o )
>             {
>                 return new DefaultPooledObject<> ( o );
>             }
>             @Override
>             public void passivateObject ( PooledObject<Set> p ) throws Exception
>             {
>                 p.getObject ().clear ();
>                 super.passivateObject ( p );
>             }
>         }, config );
>         Set set = aPool.borrowObject ();
>         set.add ( new Object () );
>         
>         aPool.returnObject ( set );
> {code}
> This is because GenericObjectPool uses a HashMap<Object, PooledObject> to correlate
objects and state. HashMap stores objects correlated to their hashCode. So in case object's
state change then hashCode will change, thus Map will fail to correlate this object since
it stores old hashCode



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message