commons-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Woonsan Ko (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (SCXML-225) Preserve order in <send> namelist attribute values
Date Mon, 02 Feb 2015 17:16:34 GMT

    [ https://issues.apache.org/jira/browse/SCXML-225?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14301471#comment-14301471
] 

Woonsan Ko commented on SCXML-225:
----------------------------------

Hi [~franck.foutou],

Thanks for the catch and the patch! I've applied the patch locally and it's just working fine
without affecting any unit tests.
I think it would be much better if we have a unit test for Send as well under src/test/java/org/apache/commons/scxml2/model/.
Not sure if you can provide a unit test as well, or I can add one later.. Please let me know
if you can.

Regards,

Woonsan

> Preserve order in <send> namelist attribute values
> --------------------------------------------------
>
>                 Key: SCXML-225
>                 URL: https://issues.apache.org/jira/browse/SCXML-225
>             Project: Commons SCXML
>          Issue Type: Improvement
>    Affects Versions: 2.0
>            Reporter: Franck Foutou
>            Priority: Minor
>             Fix For: 2.0
>
>         Attachments: Send.java.patch
>
>   Original Estimate: 1h
>  Remaining Estimate: 1h
>
> The standard allows specifying the value of the namelist attribute of the <send>
element as  space-separated list of values, which implies an ordered sequence of items. These
are later stored in org.apache.commons.scxml2.model.Send class in a HashMap where the supplied
order is lost.
> Using a LinkedHashMap would fix this issue and preserve the order of items as specified
in the XML file.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message