commons-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Benedikt Ritter (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (IMAGING-161) Move package commons.itu_t4 to formats.tiff package
Date Mon, 23 Feb 2015 19:39:11 GMT

    [ https://issues.apache.org/jira/browse/IMAGING-161?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14333704#comment-14333704
] 

Benedikt Ritter commented on IMAGING-161:
-----------------------------------------

Hello Michael,

your patch looks promising. I had hoped, that we can put all classes in itu_t4 where they
are used and make them package private. T4AndT6Compression is still public. It looks like
the compression part is only used by the tiff.write package and the decompression part is
only used by the tiff.datareaders package. Do you see chance to split the class up? That's
probably not passible since the relies on the T4_T6_Tables class.

Benedikt

> Move package commons.itu_t4 to formats.tiff package
> ---------------------------------------------------
>
>                 Key: IMAGING-161
>                 URL: https://issues.apache.org/jira/browse/IMAGING-161
>             Project: Commons Imaging
>          Issue Type: Improvement
>          Components: Format: TIFF, imaging.common.*
>            Reporter: Benedikt Ritter
>            Assignee: Benedikt Ritter
>             Fix For: Review Patch, 1.0
>
>
> All public methods from the T4AndT6Compression class are only used in the tiff package.
We should move the code to the tiff package and make it package private to remove it from
the public API.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message