commons-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Thomas Neidhart (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (MATH-1155) Speedup initialization of WellXXX rngs
Date Mon, 23 Feb 2015 22:37:11 GMT

    [ https://issues.apache.org/jira/browse/MATH-1155?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14334011#comment-14334011
] 

Thomas Neidhart commented on MATH-1155:
---------------------------------------

The reason to make the nested class protected is to allow users to create their own WELL class
with different parameters for K, M1, M2 and M3. This was possible with CM3 and if we make
the nested class package private it is not accessible anymore.

> Speedup initialization of WellXXX rngs
> --------------------------------------
>
>                 Key: MATH-1155
>                 URL: https://issues.apache.org/jira/browse/MATH-1155
>             Project: Commons Math
>          Issue Type: Improvement
>    Affects Versions: 3.3
>            Reporter: Thomas Neidhart
>             Fix For: 4.0
>
>         Attachments: MATH-1155.patch
>
>
> As identified in MATH-1154, initialization of the WellXXX rngs is quite costly as some
internal arrays have to be computed.
> Most of these initializations are specific to the type of rng, e.g. Well19937a and will
not change afterwards, thus could be initialized in a static way.
> Due to implementation details, i.e. the relevant fields are declared protected in the
base class AbstractWell, such a change would not be backwards compatible and will have to
be postponed to 4.0



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message