commons-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Gilles (JIRA)" <>
Subject [jira] [Commented] (MATH-1155) Speedup initialization of WellXXX rngs
Date Mon, 23 Feb 2015 22:35:11 GMT


Gilles commented on MATH-1155:

Being implementation details, the accessor method name could be just the name of the field

I'm not sure that having the nested class "protected" can gain anything.

> Speedup initialization of WellXXX rngs
> --------------------------------------
>                 Key: MATH-1155
>                 URL:
>             Project: Commons Math
>          Issue Type: Improvement
>    Affects Versions: 3.3
>            Reporter: Thomas Neidhart
>             Fix For: 4.0
>         Attachments: MATH-1155.patch
> As identified in MATH-1154, initialization of the WellXXX rngs is quite costly as some
internal arrays have to be computed.
> Most of these initializations are specific to the type of rng, e.g. Well19937a and will
not change afterwards, thus could be initialized in a static way.
> Due to implementation details, i.e. the relevant fields are declared protected in the
base class AbstractWell, such a change would not be backwards compatible and will have to
be postponed to 4.0

This message was sent by Atlassian JIRA

View raw message