commons-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Phil Steitz (JIRA)" <>
Subject [jira] [Closed] (DBCP-391) Close on invalid connections throws unexpected exception
Date Tue, 24 Feb 2015 03:23:20 GMT


Phil Steitz closed DBCP-391.

> Close on invalid connections throws unexpected exception
> --------------------------------------------------------
>                 Key: DBCP-391
>                 URL:
>             Project: Commons Dbcp
>          Issue Type: Bug
>    Affects Versions: 1.2.2, 1.3, 1.4
>            Reporter: Markus Stier
>             Fix For: 1.5.1, 2.0
> If the underlying connection of a PoolableConnection becomes invalid due to network errors
etc., it is not possible to remove it from the pool by using the close-strategy. In case of
an exception I'd check if the connection is already closed (=returned to pool). If not I'd
close it to return it to the pool. 
> Two problems:
> * The method isClosed() returns true, even if the PoolableConnection has not the _closed
state because of _conn.isClosed() returns true. The defective connection remains active, consuming
> * The method close throws an SQLException ("already closed") if (and only if) the underlying
connection is closed. If the PoolableConnection is in _closed state, close() returns silently
(as expected)

This message was sent by Atlassian JIRA

View raw message