commons-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Thomas Neidhart (JIRA)" <j...@apache.org>
Subject [jira] [Updated] (MATH-757) ResizableDoubleArray is not thread-safe yet has some synch. methods
Date Fri, 27 Feb 2015 15:37:04 GMT

     [ https://issues.apache.org/jira/browse/MATH-757?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Thomas Neidhart updated MATH-757:
---------------------------------
    Attachment: MATH-757.patch

I have attached a patch with the following changes:

 * remove all uses of synchronized
 * remove deprecated methods
 * make configuration fields final
 * removed static copy method (did not make sense due to the final fields)
 * updated javadoc
 * formatting

If ok (see the remark about copy method), I will resolve this issue.

> ResizableDoubleArray is not thread-safe yet has some synch. methods
> -------------------------------------------------------------------
>
>                 Key: MATH-757
>                 URL: https://issues.apache.org/jira/browse/MATH-757
>             Project: Commons Math
>          Issue Type: Bug
>            Reporter: Sebb
>             Fix For: 4.0
>
>         Attachments: MATH-757.patch
>
>
> ResizableDoubleArray has several synchronised methods, but is not thread-safe, because
class variables are not always accessed using the lock.
> Is the class supposed to be thread-safe?
> If so, all accesses (read and write) need to be synch.
> If not, the synch. qualifiers could be dropped.
> In any case, the protected fields need to be made private.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message