Return-Path: X-Original-To: apmail-commons-issues-archive@minotaur.apache.org Delivered-To: apmail-commons-issues-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 168001788F for ; Sat, 31 Jan 2015 20:48:34 +0000 (UTC) Received: (qmail 70955 invoked by uid 500); 31 Jan 2015 20:48:34 -0000 Delivered-To: apmail-commons-issues-archive@commons.apache.org Received: (qmail 70854 invoked by uid 500); 31 Jan 2015 20:48:34 -0000 Mailing-List: contact issues-help@commons.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: issues@commons.apache.org Delivered-To: mailing list issues@commons.apache.org Received: (qmail 70842 invoked by uid 99); 31 Jan 2015 20:48:34 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Sat, 31 Jan 2015 20:48:34 +0000 Date: Sat, 31 Jan 2015 20:48:34 +0000 (UTC) From: "Adrian Crum (JIRA)" To: issues@commons.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Updated] (DBCP-432) BasicDataSource createDataSource can return partially initialized DataSource MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/DBCP-432?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Adrian Crum updated DBCP-432: ----------------------------- Attachment: DBCP-432-AtomicReference.patch I'm not a DBCP expert, but maybe the attached patch will be of some use. > BasicDataSource createDataSource can return partially initialized DataSource > ---------------------------------------------------------------------------- > > Key: DBCP-432 > URL: https://issues.apache.org/jira/browse/DBCP-432 > Project: Commons Dbcp > Issue Type: Bug > Affects Versions: 2.0 > Reporter: Phil Steitz > Attachments: DBCP-432-AtomicReference.patch, DBCP-432.patch > > > The BasicDataSource instance variable, dataSource, is DCL-controlled in createDataSource; but within the sync block it is set directly and then subsequently initialized. Threads that request connections, or access createDataSource directly while initialization is in progress will get partially initialized dataSources. In particular, logWriters may be null and initial pool capacity may not be provisioned (if initialSize > 0). -- This message was sent by Atlassian JIRA (v6.3.4#6332)