Return-Path: X-Original-To: apmail-commons-issues-archive@minotaur.apache.org Delivered-To: apmail-commons-issues-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id E88AE104B5 for ; Thu, 8 Jan 2015 19:57:33 +0000 (UTC) Received: (qmail 3342 invoked by uid 500); 8 Jan 2015 19:57:34 -0000 Delivered-To: apmail-commons-issues-archive@commons.apache.org Received: (qmail 3260 invoked by uid 500); 8 Jan 2015 19:57:34 -0000 Mailing-List: contact issues-help@commons.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: issues@commons.apache.org Delivered-To: mailing list issues@commons.apache.org Received: (qmail 3248 invoked by uid 99); 8 Jan 2015 19:57:34 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 08 Jan 2015 19:57:34 +0000 Date: Thu, 8 Jan 2015 19:57:34 +0000 (UTC) From: =?utf-8?Q?Stephan_K=C3=B6ninger_=28JIRA=29?= To: issues@commons.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Updated] (IMAGING-149) Colors should check whether color components are in allowed ranges MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/IMAGING-149?page=3Dcom.atlassi= an.jira.plugin.system.issuetabpanels:all-tabpanel ] Stephan K=C3=B6ninger updated IMAGING-149: ------------------------------------- Attachment: IMAGING-149_partial_001.patch Hi,=20 I am not quite sure how to implement the behavior of this issue. Hence I ha= ve created a patch which just contains changes for ColorHsv class. Do you t= hink it is a good idea to throw IllegalArgumentExceptions when the desired = color component is out of range? In addition: How should one test it? I use= d the @Test(expected =3D IllegalArgumentException.class) Feature of JUnit. = Is it sufficient?=20 Sincerely, Stephan > Colors should check whether color components are in allowed ranges > ------------------------------------------------------------------ > > Key: IMAGING-149 > URL: https://issues.apache.org/jira/browse/IMAGING-149 > Project: Commons Imaging > Issue Type: Improvement > Components: imaging.color.* > Reporter: Benedikt Ritter > Fix For: Patch Needed > > Attachments: IMAGING-149_partial_001.patch > > > Each color in the color package should check the parameters passed into t= he constructor for validity regarding their color space. -- This message was sent by Atlassian JIRA (v6.3.4#6332)