Return-Path: 
 <issues-return-45241-apmail-commons-issues-archive=commons.apache.org@commons.apache.org>
X-Original-To: apmail-commons-issues-archive@minotaur.apache.org
Delivered-To: apmail-commons-issues-archive@minotaur.apache.org
Received: from mail.apache.org (hermes.apache.org [140.211.11.3])
	by minotaur.apache.org (Postfix) with SMTP id 463C01085A
	for <apmail-commons-issues-archive@minotaur.apache.org>;
 Fri,  2 Jan 2015 10:01:13 +0000 (UTC)
Received: (qmail 10141 invoked by uid 500); 2 Jan 2015 10:01:13 -0000
Delivered-To: apmail-commons-issues-archive@commons.apache.org
Received: (qmail 10025 invoked by uid 500); 2 Jan 2015 10:01:13 -0000
Mailing-List: contact issues-help@commons.apache.org; run by ezmlm
Precedence: bulk
List-Help: <mailto:issues-help@commons.apache.org>
List-Unsubscribe: <mailto:issues-unsubscribe@commons.apache.org>
List-Post: <mailto:issues@commons.apache.org>
List-Id: <issues.commons.apache.org>
Reply-To: issues@commons.apache.org
Delivered-To: mailing list issues@commons.apache.org
Received: (qmail 9782 invoked by uid 99); 2 Jan 2015 10:01:13 -0000
Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28)
    by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 02 Jan 2015 10:01:13 +0000
Date: Fri, 2 Jan 2015 10:01:13 +0000 (UTC)
From: "Mark Thomas (JIRA)" <jira@apache.org>
To: issues@commons.apache.org
Message-ID: <JIRA.12728195.1405687354000.125337.1420192873424@Atlassian.JIRA>
In-Reply-To: <JIRA.12728195.1405687354000@Atlassian.JIRA>
References: <JIRA.12728195.1405687354000@Atlassian.JIRA>
 <JIRA.12728195.1405687354544@arcas>
Subject: [jira] [Commented] (DBCP-423) PoolingDataSource should implement
 Closeable
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394


    [ https://issues.apache.org/jira/browse/DBCP-423?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14262819#comment-14262819 ] 

Mark Thomas commented on DBCP-423:
----------------------------------

+1 to AutoClosable. We can call out the change in behaviour in the release notes. If this was a bug fix release (i.e. 2.0.1) then I'd be concerned but I think this is OK in a 2.1 release.

> PoolingDataSource should implement Closeable
> --------------------------------------------
>
>                 Key: DBCP-423
>                 URL: https://issues.apache.org/jira/browse/DBCP-423
>             Project: Commons Dbcp
>          Issue Type: Improvement
>    Affects Versions: 2.0
>            Reporter: Christian Schneider
>             Fix For: 2.1
>
>
> Currently PoolingDataSource only implements DataSource. 
> I have the following case in ops4j pax-jdbc. I offer a DataSourceFactory in one bundle that can create a pooling DataSource.
> Then in another bundle I create DataSources based on config in ConfigurationAdmin. So when the config appears I create the DataSource, when the config goes away I have to destroy it.
> It is important to correctly dispose the DataSource as the pool has to be closed. As I can not depend on dbcp in the bundle that destroys the DataSource I currently have no simple way to destroy the DataSource.
> This is where I create the DataSource:
> https://github.com/ops4j/org.ops4j.pax.jdbc/blob/master/pax-jdbc-pool/src/main/java/org/ops4j/pax/jdbc/pool/impl/PooledDataSourceFactory.java
> I was able to solve it by a kind of hack. I extended the PoolingDataSource with a class that supports Closeable. So from the other bundle I could check if the object implements Closeable and call close.
> It would be a lot easier if PoolingDataSource would implement Closeable like I did. The same is true for GenericObjectPool and the other pools. If they would implement Closeable then handling them would be a lot easier.
> They already support a close method so it would be a small change.
> ----
> public class CloseablePoolingDataSource<C extends Connection> extends PoolingDataSource<C> implements Closeable {
>     public CloseablePoolingDataSource(ObjectPool<C> pool) {
>         super(pool);
>     }
>     @Override
>     public void close() throws IOException {
>         getPool().close();
>     }
> }



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)