commons-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <>
Subject [jira] [Commented] (LANG-1082) Add option to disable the "objectsTriviallyEqual" test in DiffBuilder.
Date Thu, 22 Jan 2015 20:13:34 GMT


ASF GitHub Bot commented on LANG-1082:

GitHub user j--baker opened a pull request:

    LANG-1082: Add ability to disable DiffBuilder trivially equal test in constructor.


You can merge this pull request into a Git repository by running:

    $ git pull LANG-1082

Alternatively you can review and apply these changes as the patch at:

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #44
commit fcdc6cb8187b11b88c314367acfd2c8ec0e2088d
Author: j--baker <>
Date:   2015-01-22T20:04:36Z

    LANG-1082: Add a second DiffBuilder constructor that provides control over the trivially
equal test.


> Add option to disable the "objectsTriviallyEqual" test in DiffBuilder.
> ----------------------------------------------------------------------
>                 Key: LANG-1082
>                 URL:
>             Project: Commons Lang
>          Issue Type: Improvement
>          Components: lang.builder.*
>    Affects Versions: 3.3.2
>            Reporter: Jonathan Baker
>            Priority: Trivial
>             Fix For: Patch Needed
>   Original Estimate: 0.25h
>  Remaining Estimate: 0.25h
> For example, a bean (e.g. a JPA record) has equals() overridden with a implementation
that tests its "id" property.   If two beans have the same ID, they correspond to the same
record in the database.  However, without tricking the objectsTriviallyEqual check in the
DiffBuilder constructor, there is no way to build a DiffResult using "before" and "after"
instances with changes to other properties (name, modification time, etc).

This message was sent by Atlassian JIRA

View raw message