commons-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Benedikt Ritter (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (LANG-1082) Add option to disable the "objectsTriviallyEqual" test in DiffBuilder.
Date Thu, 22 Jan 2015 07:41:35 GMT

    [ https://issues.apache.org/jira/browse/LANG-1082?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14287066#comment-14287066
] 

Benedikt Ritter commented on LANG-1082:
---------------------------------------

A second constructor sounds like a good solution. Note however, that the DiffBuilder itself
is not immutable, since it holds a reference to the mutable collection of diffs.

> Add option to disable the "objectsTriviallyEqual" test in DiffBuilder.
> ----------------------------------------------------------------------
>
>                 Key: LANG-1082
>                 URL: https://issues.apache.org/jira/browse/LANG-1082
>             Project: Commons Lang
>          Issue Type: Improvement
>          Components: lang.builder.*
>    Affects Versions: 3.3.2
>            Reporter: Jonathan Baker
>            Priority: Trivial
>             Fix For: Patch Needed
>
>   Original Estimate: 0.25h
>  Remaining Estimate: 0.25h
>
> For example, a bean (e.g. a JPA record) has equals() overridden with a implementation
that tests its "id" property.   If two beans have the same ID, they correspond to the same
record in the database.  However, without tricking the objectsTriviallyEqual check in the
DiffBuilder constructor, there is no way to build a DiffResult using "before" and "after"
instances with changes to other properties (name, modification time, etc).



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message