commons-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jonathan Baker (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (LANG-1081) DiffBuilder.append(String, Object left, Object right) does not do a left.equals(right) check.
Date Sun, 18 Jan 2015 15:59:34 GMT

    [ https://issues.apache.org/jira/browse/LANG-1081?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14281840#comment-14281840
] 

Jonathan Baker commented on LANG-1081:
--------------------------------------

Submitted a pull request on GitHub.com.
I hope this is the correct procedure.  Please advise.

> DiffBuilder.append(String, Object left, Object right) does not do a left.equals(right)
check.
> ---------------------------------------------------------------------------------------------
>
>                 Key: LANG-1081
>                 URL: https://issues.apache.org/jira/browse/LANG-1081
>             Project: Commons Lang
>          Issue Type: Bug
>          Components: lang.builder.*
>    Affects Versions: 3.3.2
>            Reporter: Jonathan Baker
>            Priority: Trivial
>         Attachments: DiffBuilder-equals_test_in_append_Objects.patch, DiffBuilderAppendsNonEqualObjects.java,
DiffBuilderAppendsNonEqualObjectsFixed.java
>
>   Original Estimate: 1m
>  Remaining Estimate: 1m
>
> Only testing == without testing equals() seems wrong.
> Should an equals() test be added after determining that the parameters are not arrays?



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message