commons-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Michael Groß (JIRA) <j...@apache.org>
Subject [jira] [Commented] (IMAGING-159) There should be a Parameters class
Date Fri, 30 Jan 2015 16:23:35 GMT

    [ https://issues.apache.org/jira/browse/IMAGING-159?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14298804#comment-14298804
] 

Michael Groß commented on IMAGING-159:
--------------------------------------

Thank you for your comprehensive answer. I will code a POJO.

Q: I understand that we need to deal with the situation that the user doesn't want to set
all available parameters but only one or two out of ten. Did I catch it? Because I see code
like this

{noformat}
// clear format key.
if (params.containsKey(ImagingConstants.PARAM_KEY_FORMAT)) {
     params.remove(ImagingConstants.PARAM_KEY_FORMAT);
}
{noformat}

> There should be a Parameters class
> ----------------------------------
>
>                 Key: IMAGING-159
>                 URL: https://issues.apache.org/jira/browse/IMAGING-159
>             Project: Commons Imaging
>          Issue Type: Improvement
>          Components: imaging.*
>            Reporter: Benedikt Ritter
>             Fix For: Patch Needed
>
>
> Currently options for image I/O are defined as Maps. The leads to the problem that our
code has to validate parameter types when they are used:
> {code:java}
> final Object value = params.get(PARAM_KEY_COMPRESSION);
> if (value != null) {
>   if (!(value instanceof Number)) {
>     throw new ImageWriteException(
>       "Invalid compression parameter, must be numeric: "
>          + value);
>   }
>   compression = ((Number) value).intValue();
> }
> {code}
> This can be simplified if we define a Parameters class that provides additional methods
like {{public int getInt(String key)}}. The implementation could then look up the value from
the map through an exception if it is null or not a number.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message