commons-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Benedikt Ritter (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (IMAGING-156) Refactor TagConstants
Date Sat, 10 Jan 2015 09:55:34 GMT

    [ https://issues.apache.org/jira/browse/IMAGING-156?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14272425#comment-14272425
] 

Benedikt Ritter commented on IMAGING-156:
-----------------------------------------

bq. Although this is largely a matter of taste, I believe that you are correct.

I think you will find this guide line in a lot of books. The main reason for using classes
over interfaces is, that the purpose of an interfaces is to define a contract rather. Further
more there is a lot of logic scattered around the code, which uses the constants that can
be implemented in the constant classes. I'm not sure when I'll get the time to do this, since
it is a pretty big refactoring. But I'll have a look at IMAGING-126 before.

> Refactor TagConstants
> ---------------------
>
>                 Key: IMAGING-156
>                 URL: https://issues.apache.org/jira/browse/IMAGING-156
>             Project: Commons Imaging
>          Issue Type: Improvement
>          Components: Format: TIFF
>            Reporter: Benedikt Ritter
>             Fix For: 1.0
>
>
> As discussed on the ML [1], the constant interfaces in package {{org.apache.commons.imaging.formats.tiff.constants}}
should be refactored to constant classes.
> [1] http://markmail.org/message/3s2qg5upybb62ppi



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message