commons-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Gary Lucas (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (IMAGING-156) Refactor TagConstants
Date Fri, 09 Jan 2015 19:01:34 GMT

    [ https://issues.apache.org/jira/browse/IMAGING-156?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14271715#comment-14271715
] 

Gary Lucas commented on IMAGING-156:
------------------------------------

Although this is largely a matter of taste, I believe that you are correct. I've occasionally
wondered what motivated the original author to use an interface rather than a class for this
purpose.  

If you're going to do this, you should look into committing my patch from Imaging-126 before
starting since it adds elements to one of the constants specification interfaces.

> Refactor TagConstants
> ---------------------
>
>                 Key: IMAGING-156
>                 URL: https://issues.apache.org/jira/browse/IMAGING-156
>             Project: Commons Imaging
>          Issue Type: Improvement
>          Components: Format: TIFF
>            Reporter: Benedikt Ritter
>             Fix For: 1.0
>
>
> As discussed on the ML [1], the constant interfaces in package {{org.apache.commons.imaging.formats.tiff.constants}}
should be refactored to constant classes.
> [1] http://markmail.org/message/3s2qg5upybb62ppi



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message