commons-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Sebb (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (IMAGING-151) ColorGroup.color_counts is mutable public List and is multiply sorted
Date Thu, 01 Jan 2015 23:44:13 GMT

    [ https://issues.apache.org/jira/browse/IMAGING-151?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14262686#comment-14262686
] 

Sebb commented on IMAGING-151:
------------------------------

Just noticed that ColorGroup class is package protected.
Rather confusing to have public qualifiers on all the fields and methods.

> ColorGroup.color_counts is mutable public List and is multiply sorted
> ---------------------------------------------------------------------
>
>                 Key: IMAGING-151
>                 URL: https://issues.apache.org/jira/browse/IMAGING-151
>             Project: Commons Imaging
>          Issue Type: Bug
>            Reporter: Sebb
>
> ColorGroup.color_counts is a public mutable List.
> Also the List is re-sorted in several places
> It looks like the field is only used within the package, so can be package protected.
> However it seems odd that the shared list is re-sorted by
> MedianCutLongestAxisImplementation.doCut
> and
> MedianCutMostPopulatedBoxesImplementation.performNextMedianCut (twice)



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message