commons-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Benedikt Ritter (JIRA)" <j...@apache.org>
Subject [jira] [Resolved] (VALIDATOR-345) ISINCheckDigit fails to reject invalid (non-numeric) check digits
Date Thu, 01 Jan 2015 16:41:13 GMT

     [ https://issues.apache.org/jira/browse/VALIDATOR-345?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Benedikt Ritter resolved VALIDATOR-345.
---------------------------------------
    Resolution: Fixed

{code}
$ svn ci -m "VALIDATOR-345: ISINCheckDigit fails to reject invalid (non-numeric) check digits.
Fix implemented by Sebb."
Sending        RELEASE-NOTES.txt
Sending        src/changes/changes.xml
Sending        src/main/java/org/apache/commons/validator/routines/checkdigit/ISINCheckDigit.java
Sending        src/test/java/org/apache/commons/validator/routines/checkdigit/ISINCheckDigitTest.java
Transmitting file data ....
Committed revision 1648876.
{code}

Looks good to me. I've just adjusted variable names in the test.

> ISINCheckDigit fails to reject invalid (non-numeric) check digits
> -----------------------------------------------------------------
>
>                 Key: VALIDATOR-345
>                 URL: https://issues.apache.org/jira/browse/VALIDATOR-345
>             Project: Commons Validator
>          Issue Type: Bug
>          Components: Routines
>    Affects Versions: 1.4.0 Release
>            Reporter: Sebb
>            Assignee: Benedikt Ritter
>             Fix For: 1.4.1
>
>         Attachments: VALIDATOR-345.patch
>
>
> The ISINCheckDigit class fails to check that the check digit is actually a digit; it
currently also allows some alphabetics.
> As a side effect of this, it treats some letters as being valid checkdigits when they
should be rejected.
> Patch to follow



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message